Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parcel updates causing unmount + remount. Resolves #134. #138

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Fix parcel updates causing unmount + remount. Resolves #134. #138

merged 1 commit into from
Jan 4, 2022

Conversation

joeldenning
Copy link
Member

See #134. The issue was that SingleSpaRoot was being recreated each time that getElementToRender was called, which meant that oldElement.type === newElement.type was false during React's reconciliation algorithm, causing a remount.

@joeldenning joeldenning mentioned this pull request Dec 27, 2021
Closed
@TheMcMurder TheMcMurder merged commit ce2cfba into main Jan 4, 2022
@TheMcMurder TheMcMurder deleted the issue-134 branch January 4, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMcMurder TheMcMurder TheMcMurder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeldenning @TheMcMurder