Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update single-spa-react to 6.0.1 for welcome app #394

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ibacher
Copy link
Contributor

@ibacher ibacher commented Jan 15, 2024

Reported on Slack: @single-spa/welcome dies with the message SKIP_BECAUSE_BROKEN: renderType “createRoot” did not return a function.. This updates @single-spa/welcome to use single-spa-react@^6.0.1 since the underlying issue appears to be the same as single-spa/single-spa-react#202.

Verified this fix in a local root config.

Copy link

@MilanKovacic MilanKovacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeldenning joeldenning merged commit 28a7c5f into main Jan 15, 2024
1 check passed
@joeldenning joeldenning deleted the update-single-spa-react-for-welcome-app branch January 15, 2024 21:00
@joeldenning
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants