Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Handle non-list/non-tuple input in tiledbsoma.io registration #3518

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jan 7, 2025

Issue and/or context: #3517 [sc-61390]

Changes: Allow non-list/non-tuple single-item arguments

Notes for Reviewer:

@johnkerl johnkerl changed the title [python] Check for list/tuple arguments in registrars; allow single-item arguments [python] Handle non-list/non-tuple input in tiledbsoma.io registration Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.29%. Comparing base (7addb3e) to head (02ba9df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3518      +/-   ##
==========================================
+ Coverage   86.22%   86.29%   +0.07%     
==========================================
  Files          55       55              
  Lines        6344     6357      +13     
==========================================
+ Hits         5470     5486      +16     
+ Misses        874      871       -3     
Flag Coverage Δ
python 86.29% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.29% <75.00%> (+0.07%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 439c530 into main Jan 7, 2025
11 checks passed
@johnkerl johnkerl deleted the kerl/register-type-check branch January 7, 2025 01:53
johnkerl added a commit that referenced this pull request Jan 7, 2025
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants