revert!: magnifier

[EchoEllet]

Description

Remove the magnifier due to buggy behavior with many regressions.

See #2406 for a list of issues, reasons, and details.

This reverts the two related PRs using:

git revert af691e69ed185b99899aa2dd9bb9a57620abbf05  # https://github.com/singerdmx/flutter-quill/pull/2026
git revert 2937dc8c955d02f97cf2c254da1db69799483dfc  # https://github.com/singerdmx/flutter-quill/pull/2128

And then removed anything related to the magnifier that was made in related PRs manually.

To try this branch:

dependency_overrides:
  flutter_quill:
    git:
      url: https://github.com/singerdmx/flutter-quill.git
      ref: revert/magnifier-feat

Related Issues

• Fix Revert the magnifier feature #2406
• Revert [feature] : quill add magnifier #2026
• Revert Copy TapAndPanGestureRecognizer from TextField #2128
• Fix Regression in 10.4.0: TabView within Flutter loses horizontal swipe functionality when containing multiple Quill editors #2376
• Fix Paste context menu not dismissed #2153
• Related Long Tap Selection Doesn't Trigger Selection (also Selection Handles) in iOS #2391
• Related [Android] Context menu disappears during text selection #2124
• Related [Mobile] Context Menu Remains Visible After Text Input or Paste Action #2401
• Related [Mobile] Context menu stay visible after Paste action #2111
• Related Stuck magnifying glass #2379
• Related hide magnifier when entire toolbar overlay is hidden #2402
• Related ToolbarOptions is not hidden after start typing on iOS #2412
• Related if magnifier removes toolbar, restore it when it is hidden #2049
• Related chore: move members of magnifier feature into a separate files when possible (not final yet) #2251
• Related Fix: context menu is visible even when selection is collapsed #2116
• feat!: release version 11.0.0 with breaking changes #2338 (minor cleanup, see 79a771a, f1a7e57 and b739b70)

Type of Change

• ✨ Feature: New functionality without breaking existing features.
• 🛠️ Bug fix: Resolves an issue without altering current behavior.
• 🧹 Refactor: Code reorganization, no behavior change.
• ❌ Breaking: Alters existing functionality and requires updates.
• 🧪 Tests: New or modified tests
• 📝 Documentation: Updates or additions to documentation.
• 🗑️ Chore: Routine tasks, or maintenance.
• ✅ Build configuration change: Build/configuration changes.

[EchoEllet]

This PR is not ready yet for merge. Should double-check the changes, and manually compare the changes.

Also, need to manually test the changes for possible regressions, test it before the magnifier, after it was added, and after reverting it (with this branch).

Before magnifier

$ git clone --branch v9.5.23 --depth 1 git@github.com:singerdmx/flutter-quill.git flutter-quill-before-magnifier
$ (cd flutter-quill-before-magnifier/example && flutter run)

After the magnifier with all changes and fixes

$ git clone --branch v11.0.0-dev.14 --depth 1 git@github.com:singerdmx/flutter-quill.git flutter-quill-latest-with-magnifier
$ (cd flutter-quill-latest-with-magnifier/example && flutter run)

After reverting the magnifier

$ git clone --branch revert/magnifier-feat --depth 1 git@github.com:singerdmx/flutter-quill.git flutter-quill-without-magnifier
$ (cd flutter-quill-without-magnifier/example && flutter run)

Videos

No issues, and seem to work as before:

AndroidApi35Test.mov

iOS16Test.mov

Critical Issue

A buggy behavior reproduced after the revert; need to test it before and after the magnifier too:

AndroidBuggyBehavior.mov

[EchoEllet]

@CatHood0 Let me know if you need more time for future PRs.

[EchoEllet]

Related #2414

[CatHood0]

@EchoEllet No problem now that i'm freer. I plan to start finishing the PRs that I still have active.

[EchoEllet]

I plan to start finishing the PRs that I still have active.

I appreciate your activity, but we need to discuss the issues before adding new features that affect the editor experience. We definitely don't want to repeat the same mistake of the magnifier.