Fix: Resolved issue with broken IME composing rect in Windows desktop(re-implementation) #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… app - Fixed issue where the composing rect would break during IME conversion. - When the composing region is unknown, it now avoids calling setComposingRect on TextInputConnection.
|
@singerdmx Can we review the changes before merging PRs as we discussed this in previous issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have re-implemented the changes from #2239 that were previously reverted. In this implementation, when the ComposingRange has an invalid position, the position is no longer updated in TextInputConnection. During the composing phase, the correct ComposingRange is generally retrieved, and the display position is determined based on that information, so no issues occur. The exception that caused the revert has also been resolved. I have confirmed that this behavior works correctly across Windows, Mac, Web, iOS, and Android.
Before:
https://github.com/user-attachments/assets/3afd158f-73f1-45ba-b56e-56ff4c9b965a
After:
https://github.com/user-attachments/assets/e9246da5-6ed0-416d-b358-36bc83f74c62
Related Issues
Type of Change
Suggestions