Tap trustpilot intial changes - Discover mode, Sync mode, bulk request. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisPersonal
reviewed
Jun 8, 2022
CHANGELOG.md
Outdated
| ## 0.2.0 | ||
| * Fixed Discovery mode to add metadata and other missing fields in catalog.json | ||
| * Fixed Sync mode to extract data | ||
| * Changed consumer profile endpoint to extract data in bulk mode |
There was a problem hiding this comment.
This should be done as part of Bump version. Please remove this change for right now
setup.py
Outdated
| @@ -3,16 +3,23 @@ | |||
|
|
|||
| setup( | |||
| name="tap-trustpilot", | |||
| version="0.1.0", | |||
| version="0.2.0", | |||
There was a problem hiding this comment.
This again should be changed as part of Bump version
| "requests", | ||
| ], | ||
| extras_require={ |
There was a problem hiding this comment.
Please add comments to the code
RushiT0122
approved these changes
Jun 8, 2022
…tap-trustpilot into tap-trustpilot/intial_changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Code has been refactored to generate the catalog.json as per the stitch data standards (discover mode). Created separate file to handle the discover mode logic.
Modified sync mode logic to accept the command line arguments.
Modified consumers stream logic to handle the bulk request.
Added circleci config.yml and changelog.md.
Unit tests and integration tests are yet to be done.
Manual QA steps
Risks
Rollback steps