Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap trustpilot intial changes - Discover mode, Sync mode, bulk request. #1

Merged
merged 14 commits into from
Jun 8, 2022

Conversation

sgandhi1311
Copy link
Member

Description of change

Code has been refactored to generate the catalog.json as per the stitch data standards (discover mode). Created separate file to handle the discover mode logic.
Modified sync mode logic to accept the command line arguments.
Modified consumers stream logic to handle the bulk request.
Added circleci config.yml and changelog.md.
Unit tests and integration tests are yet to be done.

Manual QA steps

Risks

Rollback steps

  • revert this branch

Copy link
Collaborator

@KrisPersonal KrisPersonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have unit test cases?

CHANGELOG.md Outdated
## 0.2.0
* Fixed Discovery mode to add metadata and other missing fields in catalog.json
* Fixed Sync mode to extract data
* Changed consumer profile endpoint to extract data in bulk mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done as part of Bump version. Please remove this change for right now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

setup.py Outdated
@@ -3,16 +3,23 @@

setup(
name="tap-trustpilot",
version="0.1.0",
version="0.2.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This again should be changed as part of Bump version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"requests",
],
extras_require={
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to the code

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@RushiT0122 RushiT0122 self-requested a review June 8, 2022 15:49
@kethan1122 kethan1122 merged commit 6fa1dfd into master Jun 8, 2022
@kethan1122 kethan1122 mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants