Use inclusive comparison for emitting records #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stitchdata.atlassian.net/browse/SUP-892
A bug was introduced when we last refactored the sync where we request records using
gte, but emit records using a strictlygreater thancomparison on the bookmark. This could cause records at the date window boundary to be missed.It affects immutable streams (balance_transactions and events) and any records that have not been updated (the update code does not have this issue, since it is aware that events may have the same created time and specifically uses strict
>to always emit the most recent event).Co-Author: @jacobrobertbaca