Fix unterminated strings issue #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unterminated strings issue
dmosorast
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unterminated strings issue #4
Description of change
Increased request timeout, decreased max page limit, and added a retry for unterminated strings errors in client.
Manual QA steps
Ran singer-discover for Discovery for ALL endpoints and fields: no errors. Ran singer-check-tap for ALL endpoints: no errors. Ran target-stitch import API for ALL endpoints with previous state file: no errors.
Risks
Low risk. No new endpoints or fields. Uses same version of the Recharge API. Only minor change to fix intermittent unterminated string errors.
Rollback steps
Revert this branch to 1.1.2