removes date datatype support from the tap code #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
changed the title
cosimon
reviewed
Mar 7, 2024
Comment on lines
64
to
85
| def test_null_date_effectiveFormat(self): | ||
| """ | ||
| Test when no value is given in second row of date, discovery is locking at 'effectiveFormat'. | ||
| And returns type and format in schema according to that. | ||
| """ | ||
| sheet = SHEET | ||
| sheet["data"][0]["rowData"][1]["values"][0]["effectiveFormat"]["numberFormat"]["type"] = "DATE" | ||
|
|
||
| expected_format = { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ], | ||
| "format": "date" | ||
| } | ||
|
|
||
| sheet_json_schema, columns = schema.get_sheet_schema_columns(sheet) | ||
| returned_formats = sheet_json_schema["properties"]["Column1"]["anyOf"] | ||
|
|
||
| # verify the returned schema has expected field types and format | ||
| self.assertIn(expected_format,returned_formats) | ||
|
|
There was a problem hiding this comment.
I think there is still value in this test as the format is different from the above test.
cosimon
approved these changes
Mar 7, 2024
sgandhi1311
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-24742 - Removes DATE datatype support from the tap code
Manual QA steps
Risks
Rollback steps