TDL-14448 Numbertype falls to string for boolean values #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrata270998
changed the title
savan-chovatiya
suggested changes
Apr 14, 2022
Comment on lines
242
to
245
| # BUG_TDL-14448 | https://jira.talendforge.org/browse/TDL-14448 | ||
| # Skipping Number and Currency columns with boolean values because they do not fallback to string | ||
| elif test_case == 'boolean' and column in {'Currency', 'Number'}: # BUG_TDL-14448 | ||
| continue # skip | ||
| # elif test_case == 'boolean' and column in {'Currency', 'Number'}: # BUG_TDL-14448 | ||
| # continue # skip |
There was a problem hiding this comment.
If we have resolved this issue then we should remove this section rather than commenting it.
There was a problem hiding this comment.
Removed the commented code
| """Verify that boolean values falls back as string""" | ||
| value = True | ||
| transformed_data = transform_sheet_number_data(value, sheet_title='test-sheet', col_name='test-column', col_letter='col', row_num=1, col_type='numberType') | ||
| self.assertIsInstance(transformed_data, str) |
There was a problem hiding this comment.
Also, add an assertion for the value of transformed_data in all unit tests.
There was a problem hiding this comment.
Added the assertion
savan-chovatiya
approved these changes
May 2, 2022
dbshah1212
approved these changes
May 2, 2022
KrisPersonal
approved these changes
May 6, 2022
kspeer825
approved these changes
May 9, 2022
RushiT0122
approved these changes
May 17, 2022
…sheets into TDL-14448-numbertype-falls-to-string-for-boolean
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
May 31, 2022
* TDL-7096 used effective format to check the type instead of effective value (#76) * TDL-7096 used eff format to check the type instead of eff value * added integration test for the updated code * added new sheet in schema * TDL-18745 changed to formatted, and made 2 API calls for datetime values (#75) * TDL-18745 changed to formatted, and made 2 API calls for datetime values * added cftime in setup.py * added extra check for currency * added unittsts for currency format and fixed cci * added comments back * resolved PR comments * transform into datetime, if error, return string values * added unittests * resolved PR comments * resolved review comments * added sadsheet-date in sync * added sadsheet-effective-format to base.py for schema * added new test sheet * added sheet to skip * fixed unittests * TDL-14454 Changed multipleof to singer.decimal (#74) * changed multipleof to singer.decimal * fixed cci issues * fixed cci failures * converted int to str list * fixed circlci * removed unused import * resolved comments * added sheets in base * skipped streams due to errors * added test-sheet-number in base * TDL-14448 Numbertype falls to string for boolean values (#73) * initial commit * unittests for number transform * intgration test update * deleted test.py * resolve PR comments * resolved cci failures * changed currency to string as it would now come as a string
Merged
namrata270998
deleted the
TDL-14448-numbertype-falls-to-string-for-boolean
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps