Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test add pad and ignore hidden sheets #35

Merged
merged 4 commits into from
May 24, 2021
Merged

Test add pad and ignore hidden sheets #35

merged 4 commits into from
May 24, 2021

Conversation

zachharris1
Copy link
Contributor

@zachharris1 zachharris1 commented May 21, 2021 •
edited
Loading

Description of change

This commit mostly duplicates #12 . Note that this change does not seem to affect hidden sheets

Manual QA steps

  • Ran syncs with empty first row of data, partially empty first row of data

Risks

  • low

Rollback steps

  • revert this branch

@cosimon cosimon merged commit 2497387 into master May 24, 2021
@cosimon cosimon deleted the test_Add_pad_and_ignore_hidden_sheets branch May 24, 2021 18:08
@cosimon cosimon mentioned this pull request May 24, 2021
Merged
@zachharris1 zachharris1 mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimon cosimon cosimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zachharris1 @cosimon @dscoleman @KAllan357