-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TDL-14475 added unsupported feature and unittests (#47)
* added unsupported feature and unittests * added code comments * fixed indent * fixed indentation * resolved a bug of writing md when 2 consecutive empty headers * updated the logic for consecutive empty headers * rsolved comments * added test case for consecutive empty headers * added comments * resolved circleci errors * resolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
- Loading branch information
3 people
authored
Dec 13, 2021
1 parent
98e032a
commit d76ae96
Showing
3 changed files
with
212 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,191 @@ | ||
| from tap_google_sheets.client import GoogleClient | ||
| import unittest | ||
| from unittest import mock | ||
| from tap_google_sheets import schema | ||
|
|
||
| class TestUnsupportedFields(unittest.TestCase): | ||
| @mock.patch('tap_google_sheets.GoogleClient.get') | ||
| def test_unsupported_fields(self, mocked_get): | ||
| """ | ||
| Test whether the incusion property for the skipped property is changed to `unsupported` | ||
| and the description is added in the schema | ||
| """ | ||
| sheet = { | ||
| "sheets": [{ | ||
| "properties": { | ||
| "sheetId": 0, | ||
| "title": "Sheet1", | ||
| "index": 0, | ||
| "sheetType": "GRID", | ||
| "gridProperties": { | ||
| "rowCount": 3, | ||
| "columnCount": 26 | ||
| } | ||
| }, | ||
| "data": [ | ||
| { | ||
| "rowData": [ | ||
| { | ||
| "values": [ | ||
| {}, | ||
| { | ||
| "formattedValue": "abc" | ||
| }, | ||
| { | ||
| "formattedValue": "def" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "values": [ | ||
| { | ||
| "formattedValue": "A" | ||
| }, | ||
| { | ||
| "formattedValue": "B" | ||
| }, | ||
| { | ||
| "formattedValue": "4" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ]} | ||
| ] | ||
| } | ||
| expected_schema = { | ||
| "type": "object", | ||
| "additionalProperties":False, | ||
| "properties": { | ||
| "__sdc_spreadsheet_id": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "__sdc_sheet_id": { | ||
| "type": [ | ||
| "null", | ||
| "integer" | ||
| ] | ||
| }, | ||
| "__sdc_row": { | ||
| "type": [ | ||
| "null", | ||
| "integer" | ||
| ] | ||
| }, | ||
| "__sdc_skip_col_01": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ], | ||
| "description": "Column is unsupported and would be skipped because header is not available" | ||
| }, | ||
| "abc": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "def": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| mocked_get.return_value = sheet | ||
| schemas, field_metadata = schema.get_schemas(GoogleClient('client_id', 'client_secret', 'refresh_token'), 'sheet_id') | ||
| # check if the schemas are equal, hence verifying if the description is present | ||
| self.assertEqual(expected_schema, schemas["Sheet1"]) | ||
| for each in field_metadata["Sheet1"]: | ||
| if each["breadcrumb"] and '__sdc_skip_col_01' in each["breadcrumb"]: | ||
| # check if the inclusion property is updated to `unsupported` | ||
| self.assertEqual(each["metadata"]["inclusion"], "unsupported") | ||
|
|
||
| def test_two_skipped_columns(self): | ||
| """ | ||
| Test whether the columns has the `prior_column_skipped` key which is True as there ar 2 consecutive empty headers | ||
| and the `sheet_json_schema` has only 3 keys | ||
| """ | ||
| sheet = { | ||
| "properties":{ | ||
| "sheetId":1825500887, | ||
| "title":"Sheet11", | ||
| "index":2, | ||
| "sheetType":"GRID", | ||
| "gridProperties":{ | ||
| "rowCount":1000, | ||
| "columnCount":26 | ||
| } | ||
| }, | ||
| "data":[ | ||
| { | ||
| "rowData":[ | ||
| { | ||
| "values":[ | ||
| {}, | ||
| {}, | ||
| { | ||
| "formattedValue":"abd", | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "values":[ | ||
| { | ||
| "formattedValue":"1", | ||
| }, | ||
| { | ||
| "formattedValue":"3", | ||
| }, | ||
| { | ||
| "formattedValue":"45", | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "rowMetadata":[ | ||
| { | ||
| "pixelSize":21 | ||
| } | ||
| ], | ||
| "columnMetadata":[ | ||
| { | ||
| "pixelSize":100 | ||
| }, | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| expected_columns = [ | ||
| { | ||
| 'columnIndex': 1, | ||
| 'columnLetter': 'A', | ||
| 'columnName': '__sdc_skip_col_01', | ||
| 'columnType': 'stringValue', | ||
| 'columnSkipped': True, | ||
| 'prior_column_skipped': True | ||
| } | ||
| ] | ||
| expected_schema = { | ||
| 'type': 'object', | ||
| 'additionalProperties': False, | ||
| 'properties': { | ||
| '__sdc_spreadsheet_id': { | ||
| 'type': ['null', 'string'] | ||
| }, | ||
| '__sdc_sheet_id': { | ||
| 'type': ['null', 'integer'] | ||
| }, | ||
| '__sdc_row': { | ||
| 'type': ['null', 'integer'] | ||
| } | ||
| } | ||
| } | ||
| sheet_json_schema, columns = schema.get_sheet_schema_columns(sheet) | ||
| self.assertEqual(sheet_json_schema, expected_schema) # test the schema is as expected | ||
| self.assertEqual(columns, expected_columns) # test if the columns is as expected |