Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new stream: ad_insights_hourly_advertiser #151

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Conversation

luandy64
Copy link
Contributor

Description of change

This PR adds a new Ad Insights Stream: ads_insights_hourly_advertiser.

Notes

Excluded field

  • dda_results is a field that appears in the Facebook Docs. However, I did not have test data for it and did not see anything in their docs about this field. So I have excluded it from being syncable in the tap

Breakdown Behavior

Here's a blog post from Facebook announcing this new breakdown.

In that link, you'll see that you can request data for multiple days at a time.

For example, your request could contain date_start = 2021-01-01 and date_end = 2021-01-02. While it's understandable that you get 48 data points out of this (one for each hour of the entire date range), that's not how this API works. It will aggregate all of the data for 01:00 - 02:00 for every day in the date range.

Because of this behavior, we have chosen to ask for a day's worth of data at a time, hoping that allows you to aggregate however you want in your warehouse.

Manual QA steps

  • Available fields:
    • To create the schema file here, I grabbed every field from the Facebook SDK object and attempted to make a report with it. After some trial and error, I found that one field would cause an error if included, full_view_reach, so I took it out of the request.

Risks

  • Low:
    • It's a new stream. Existing integrations can safely ignore it.
    • Anyone that wants this data should be able to run Discovery again and select it
    • There are no new scopes associated with fetching this data since it's just an AdsInsight Stream

Rollback steps

  • revert this branch, bump the version

@luandy64 luandy64 merged commit d969c98 into master Jun 15, 2021
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* Add new stream: ads_insights_hourly_advertiser

* Add new stream to tests

* Get tests passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants