Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add leads stream #143

Merged
merged 16 commits into from
Apr 13, 2021
Merged

Add leads stream #143

merged 16 commits into from
Apr 13, 2021

Conversation

zachharris1
Copy link
Contributor

@zachharris1 zachharris1 commented Apr 5, 2021 •
edited
Loading

Description of change

Adds a leads stream which emits leads from lead ads.

The Leads stream requires several new oauth scopes. Because of this, we're shipping this pr with the stream disabled

Manual QA steps

  • got data through for leads stream

Risks

  • Most of the risk involved with this change involves the need to add new oauth scopes, but if those scopes aren't added it should just break the leads stream

Rollback steps

  • revert this branch

@zachharris1 zachharris1 changed the title Add leads stream and rework AdCreative stream Add leads stream Apr 12, 2021
@zachharris1 zachharris1 merged commit 681fd21 into master Apr 13, 2021
@zachharris1 zachharris1 deleted the add/leads-stream branch April 13, 2021 19:44
@zachharris1 zachharris1 mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimon cosimon cosimon approved these changes

@KAllan357 KAllan357 KAllan357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachharris1 @KAllan357 @cosimon