Updated tap-calendly as per the latest api reference #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new fields in streams.py as per latest calendly api reference. For each stream mentioned in streams.py, there were certain fields like invitees_counter, cancellation in events stream, which were mentioned in the latest api reference. These fields have been added. - made changes to setup.py. Setup.py did not have entry_points, classifiers, and modules mentioned. Added that. - Made changes to get_next_page_token in client.py, where it takes the next_page_token directly from the json response, instead of parsing the next page url for next_page_token -Made changes to config.sample.json, where start_date's format has been changed as per the api reference.
|
Hi @shreejeet-atidiv, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @shreejeet-atidiv! Thank you for signing the Singer Contribution License Agreement. |
shreejeetsahayold
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
(write a short description or paste a link to JIRA)
Manual QA steps
Risks
Rollback steps