Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-19044: Add phone field to list of supported fields #30

Closed
wants to merge 2 commits into from
Closed

TDL-19044: Add phone field to list of supported fields #30

wants to merge 2 commits into from

Conversation

jtilala
Copy link

@jtilala jtilala commented Jun 2, 2022

Description of change

  • Add a new field (i.e. Phone) in the stream contacts schema json

Manual QA steps

  • Check that in sync mode we are getting data for the phone field or not.

Risks

Rollback steps

  • revert this branch

Merge branch 'master' of https://github.com/singer-io/tap-activecampaign
3544417 
 into TDL-19044-Add-phone-field-to-list-of-supported-fields
@RushiT0122
Copy link
Contributor

Is this change getting covered in unit tests or integration tests?

@jtilala
Copy link
Author

jtilala commented Jun 22, 2022

Is this change getting covered in unit tests or integration tests?

In this change, we have added a new field in the "contacts.json". So it is already been covered in "test_all_fields.py".

@shantanu73
Copy link
Contributor

This is a duplicate PR, so closing this.
PR reference : #26

@shantanu73 shantanu73 closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantanu73 shantanu73 shantanu73 approved these changes

@dbshah1212 dbshah1212 dbshah1212 approved these changes

@savan-chovatiya savan-chovatiya savan-chovatiya approved these changes

@RushiT0122 RushiT0122 RushiT0122 approved these changes

@KrisPersonal KrisPersonal Awaiting requested review from KrisPersonal

@nitingaikwad1 nitingaikwad1 Awaiting requested review from nitingaikwad1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtilala @RushiT0122 @shantanu73 @dbshah1212 @savan-chovatiya