TDL-18288: Add after param for activities stream
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
approved these changes
Mar 28, 2022
savan-chovatiya
approved these changes
Apr 8, 2022
hpatel41
requested review from
KrisPersonal,
kspeer825,
RushiT0122 and
dmosorast
kspeer825
approved these changes
Apr 22, 2022
|
|
||
| @mock.patch('requests.Session.request') | ||
| @mock.patch('tap_activecampaign.streams.Activities.process_records') | ||
| def test_activities_stream_params(self, mocked_process_records, mocked_request): |
There was a problem hiding this comment.
Could this test be executed at a higher level in the tap logic? What sets the after date that is passed to the sync function?
There was a problem hiding this comment.
There is a condition in the sync function which checks, if bookmark_query_field is set or not. If it is set, bookmark_query_field's value (here after) will be added to the query params and the date will be assigned to it.
KrisPersonal
approved these changes
Jun 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-18288: Add
afterparam for activities streamafterparam for activities streamordersparam to sort the response in ascending order of tstampManual QA steps
Risks
Rollback steps