-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-18288: Add after
param for activities stream
#24
TDL-18288: Add after
param for activities stream
#24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
||
@mock.patch('requests.Session.request') | ||
@mock.patch('tap_activecampaign.streams.Activities.process_records') | ||
def test_activities_stream_params(self, mocked_process_records, mocked_request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this test be executed at a higher level in the tap logic? What sets the after
date that is passed to the sync function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a condition in the sync
function which checks, if bookmark_query_field
is set or not. If it is set, bookmark_query_field's value (here after
) will be added to the query params and the date will be assigned to it.
Description of change
TDL-18288: Add
after
param for activities streamafter
param for activities streamorders
param to sort the response in ascending order of tstampManual QA steps
Risks
Rollback steps