Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-18032: Fix the transformation error of forms stream #22

Merged
merged 1 commit into from
Mar 4, 2022
Merged

TDL-18032: Fix the transformation error of forms stream #22

merged 1 commit into from
Mar 4, 2022

Conversation

savan-chovatiya
Copy link
Contributor

Description of change

TDL-18032: Fix transformation error.

  • Currently, the schema of the recent field is like below so it expects an array of objects but the customer is getting an array of strings also so it throws an error.
  • Added string also in the array part of the schema for the recent field.

Manual QA steps

  • The mocked API call to return data as same as customer's record and verified that no transformation error there and data emitted successfully.

Risks

Rollback steps

  • revert this branch

@KrisPersonal KrisPersonal merged commit 778b492 into master Mar 4, 2022
@dlackty dlackty mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisPersonal KrisPersonal KrisPersonal approved these changes

@karanpanchal-crest karanpanchal-crest Awaiting requested review from karanpanchal-crest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savan-chovatiya @KrisPersonal