TDL-16481 Update schema #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prijendev
commented
Jan 5, 2022
| @@ -25,6 +25,6 @@ def transform_json(this_json, stream_name, data_key): | |||
| else: | |||
| converted_json = humps.decamelize(this_json) | |||
|
|
|||
| fixed_records = fix_records(converted_json) | |||
| fix_records(converted_json) | |||
There was a problem hiding this comment.
Fixed pylint error assignment-from-no-return. (Reference)
dbshah1212
approved these changes
Jan 11, 2022
karanpanchal-crest
approved these changes
Jan 12, 2022
Comment on lines
+15
to
+29
| "anyOf": [ | ||
| { | ||
| "type": ["null", "object"], | ||
| "additionalProperties": true, | ||
| "properties": {} | ||
| }, | ||
| { | ||
| "type": "array", | ||
| "items": { | ||
| "type": ["null", "object"], | ||
| "additionalProperties": true, | ||
| "properties": {} | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
Will this update to schema be backward compatible?
There was a problem hiding this comment.
Yes, we have made this change just to handle the empty array value of the param field. In the existing schema, it handles only object type values that are still supported. So, now it will handle the following both possible values of the param field,
- "param": {"eventType": "never"}
- "param": []
KrisPersonal
approved these changes
Jan 13, 2022
kspeer825
approved these changes
Jan 13, 2022
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
Jan 31, 2022
* TDL-16481 Update schema (#10) * updated typo in schemas * Updated test case * Updated config.yml file * Fixed automation_blocks stream * TDL-16549 implement request timeout (#12) * TDL-16549 implement request timeout * Updated config.yml file * Fixed integration test case failure * resolved comments * resolved comments Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-16386 Refactor error handling (#8) * Initial commit for error handling * updated error handling * Updated backoff for 5xx error * Updated unit test cases * Updated config.yml file * Resolved pylint error * Added ConnectionResetError exception * Updated raise_for_error method * Updated comments in the code * TDL-16383 Refactor code to class based (#9) * Updated dict based to class based * Updated parent child format * Updated config file * Updated config file * Resolved circleci error * Fixed circleci issue * Removed integration test case snippet from config file * Added comments in the code * Resolved comments * Added comment for process_records function * Updated comments * TDL 16384 check best practices and TDL 16465 Make replication key with automatic inclusion (#11) * Initial commit for best practices * Updated integration test case as per client account data * Added back site_messages stream in pagination test * Updated config file * Fixed circleci issue * Updated tap-teser version * Fixed test case issue * Added test in config.yml * Fixed start_date test case * Updated discover test case. * Added comments * Added test case reference link * Removed comments * Removed slack notifier * Added slack status in config.yml * UPdated config.yml version * Added context in build_daily Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
paramsof automation_blocks to support empty array data type.Manual QA steps
Risks
Rollback steps