-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-16481 Update schema #10
Conversation
@@ -25,6 +25,6 @@ def transform_json(this_json, stream_name, data_key): | |||
else: | |||
converted_json = humps.decamelize(this_json) | |||
|
|||
fixed_records = fix_records(converted_json) | |||
fix_records(converted_json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed pylint error assignment-from-no-return. (Reference)
"anyOf": [ | ||
{ | ||
"type": ["null", "object"], | ||
"additionalProperties": true, | ||
"properties": {} | ||
}, | ||
{ | ||
"type": "array", | ||
"items": { | ||
"type": ["null", "object"], | ||
"additionalProperties": true, | ||
"properties": {} | ||
} | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this update to schema be backward compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have made this change just to handle the empty array value of the param field. In the existing schema, it handles only object type values that are still supported. So, now it will handle the following both possible values of the param
field,
- "param": {"eventType": "never"}
- "param": []
* TDL-16481 Update schema (#10) * updated typo in schemas * Updated test case * Updated config.yml file * Fixed automation_blocks stream * TDL-16549 implement request timeout (#12) * TDL-16549 implement request timeout * Updated config.yml file * Fixed integration test case failure * resolved comments * resolved comments Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-16386 Refactor error handling (#8) * Initial commit for error handling * updated error handling * Updated backoff for 5xx error * Updated unit test cases * Updated config.yml file * Resolved pylint error * Added ConnectionResetError exception * Updated raise_for_error method * Updated comments in the code * TDL-16383 Refactor code to class based (#9) * Updated dict based to class based * Updated parent child format * Updated config file * Updated config file * Resolved circleci error * Fixed circleci issue * Removed integration test case snippet from config file * Added comments in the code * Resolved comments * Added comment for process_records function * Updated comments * TDL 16384 check best practices and TDL 16465 Make replication key with automatic inclusion (#11) * Initial commit for best practices * Updated integration test case as per client account data * Added back site_messages stream in pagination test * Updated config file * Fixed circleci issue * Updated tap-teser version * Fixed test case issue * Added test in config.yml * Fixed start_date test case * Updated discover test case. * Added comments * Added test case reference link * Removed comments * Removed slack notifier * Added slack status in config.yml * UPdated config.yml version * Added context in build_daily Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com>
Description of change
params
of automation_blocks to support empty array data type.Manual QA steps
Risks
Rollback steps