Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversed order checking for WMIC or Powershell #18

Merged
merged 15 commits into from
Jun 8, 2020
Merged

Reversed order checking for WMIC or Powershell #18

merged 15 commits into from
Jun 8, 2020

Conversation

landsfiskalen
Copy link
Contributor

@landsfiskalen landsfiskalen commented Jun 2, 2020

Ok, I reversed the order checking for WMIC or Powershell. Should be more compatible to 3.2 now.

Fixes #17
Fixes #16

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@landsfiskalen
Copy link
Contributor Author

Man, this Git stuff is hard. I'm completely new to this, but I think I've managed to resolve it now?

@landsfiskalen
Copy link
Contributor Author

Gaaah! Managed to close the pull request.

@landsfiskalen landsfiskalen reopened this Jun 7, 2020
@sindresorhus sindresorhus merged commit fe33032 into sindresorhus:master Jun 8, 2020
@sindresorhus
Copy link
Owner

Tip: You should never to PRs from master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs when running v3.3 on Windows Server 2012 R2 Causing aroung 800ms delay between version 3.2.0 and 3.3.0
2 participants