Fix: CamelCasedPropertiesDeep changing tupleto array #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmk1c
changed the title
| }; | ||
| : Value extends [] | ||
| ? [] | ||
| // Tailing spread array |
|
It should be a separate helper type, like in https://github.com/sindresorhus/type-fest/blob/main/source/delimiter-cased-properties-deep.d.ts It would also be useful with a comment to indicate where it's copied from, to make it easier to keep them in sync. |
voxpelli
reviewed
Feb 21, 2024
|
@pmk1c Bump :) |
pmk1c
force-pushed
the
fix/817
branch
3 times, most recently
from
7442936 to
b8c233e
Compare
|
Sorry for letting you wait. I also tried merging I'd think this is good for now. |
sindresorhus
reviewed
May 3, 2024
| }; | ||
|
|
||
| // This is a copy of DelimiterCasedPropertiesArrayDeep (see: delimiter-cased-properties-deep.d.ts). | ||
| // These types should be kept in sync. |
There was a problem hiding this comment.
You need to add this text to DelimiterCasedPropertiesArrayDeep too, otherwise it could get out of sync with this one.
…lCasedPropertiesDeep to fix changing tuple-type to array-type
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #817