Fix undefined function #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is something you should handle, not the throttle function. The throttle is documented to accept a non-optional function (in readme and TS). Either guard the call, or pass in a noop function as fallbacK; |
|
Alright, thanks for the feedback - I think using a noop function instead as fallback is a good idea. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using your excellent library in a React Native project, and stumbled onto an issue where some native elements would trigger the throttled functions without any callback. This would trigger a unhandled exception that would crashes the application.
To fix this I simply added the optional chaining operator
?.to thefunction_argument, so that iffunction_is not set - it will not be called.