Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pFilterIterable #7

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Add pFilterIterable #7

merged 6 commits into from
Dec 22, 2023

Conversation

noamokman
Copy link
Contributor

@noamokman noamokman commented Dec 18, 2023 •
edited
Loading

Hey!

I wanted to add pFilterIterable to be able to filter async iterables.

I'm using pMapIterable and the code is pretty simple.

Added tests and types,
Let me know if I missed anything.

Thanks!

danielwitz
danielwitz approved these changes Dec 18, 2023
View reviewed changes
Copy link

@danielwitz danielwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@noamokman
Copy link
Contributor Author

@sindresorhus can you take a look? 🙏🏻

sindresorhus
sindresorhus requested changes Dec 19, 2023
View reviewed changes
@sindresorhus sindresorhus merged commit 1d093e6 into sindresorhus:main Dec 22, 2023
1 check passed
@sindresorhus
Copy link
Owner

Thanks :)

@noamokman noamokman deleted the add-p-filter-iterable branch December 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

@danielwitz danielwitz danielwitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noamokman @sindresorhus @danielwitz