New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent extra leading whitespace in stopAndPersist when symbol i… #243

Merged

sindresorhus merged 1 commit into sindresorhus:main from zhanxiaoge:fix/symbol-empty-string

Nov 1, 2024

+2 −1

Contributor

zhanxiaoge commented Oct 29, 2024

Summary
When using stopAndPersist with { symbol: '', text: 'text...' }, an extra leading whitespace appears before the text in the terminal.

Example Code

import ora from 'ora';

const spinner = ora().start('Ora Start');

setTimeout(() => {
  spinner.stopAndPersist({ symbol: '', text: 'Ora Stop' });
}, 1000);


          fix: prevent extra leading whitespace in stopAndPersist when symbol i…

7bd3ca0

…s an empty string.

sindresorhus merged commit 5117dfb into sindresorhus:main

3 checks passed

zhanxiaoge deleted the fix/symbol-empty-string branch

November 13, 2024 12:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet