-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+C is ignored on macOS #130
Comments
// @stroncium |
Some googling tells me the proper way to emit Ctrl+C on Mac is Command+ I could try to find some mac to test it on, but it would probably be much faster if someone tests it and tells me what sequences are emitted on mac for such shortcuts when tty is read in raw mode. |
Looks like it is somehow connected to Still not sure why it is happening but it looks like it doesn't work when I awaiting But, still, reverting to v3 or using |
Could you post some reduced example then(need to see ora options, execa options)? It may be the problem isn't unique to macs. |
I've reproduced this issue on macOS and Linux. The special handling of CTRL-C in #112 is not working as intended. I can confirm the workaround of reverting back to v3 or using
Hit CTRL-C during "First spinner" terminates the program. During "Second spinner" CTRL-C does not terminate the program as expected. |
So, how to fix it? |
Change introduced by #112 is ignoring ctrl+c on macOS.
Reverting back to v3 or using
discardStdin: false
fixes it.Ora version: 4.0.1
macOS version: 10.15 Beta (Catalina)
The text was updated successfully, but these errors were encountered: