Fixed incorrect changed path when mutating unrelated area of proxy during iteration operations on cloned areas of the proxy. #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your fantastic library in a side project, and I picked up an edge case that occurs when iterating over some part of the proxy and during that iteration modify a different part of the proxy. In this case the change path reported as the property currently being iterated over instead of the mutated property.
For example, if I have this object:
And I do the following:
The expected change path is
b.c
, however, it is reported asa
.The issue seems to be that the
handleChange
would detect that aSmartClone
is active, due to theforEach
, and therefore branch into the logic for updating the clone without first checking if the change path applies to the clone.