Add registryUrl option
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Mar 18, 2019
sindresorhus
changed the title
registryUrl option
itaisteinherz
commented
Mar 20, 2019
itaisteinherz
commented
Mar 20, 2019
|
@sindresorhus It would be great if you could take another look at this, as it's currently blocking sindresorhus/np#424. |
sindresorhus
reviewed
Jun 3, 2019
|
You need to add the actual option to the TS definition. See https://github.com/sindresorhus/typescript-definition-style-guide |
|
@sindresorhus Done |
sindresorhus
reviewed
Jun 9, 2019
sindresorhus
reviewed
Jun 9, 2019
sindresorhus
reviewed
Jun 9, 2019
sindresorhus
reviewed
Jun 9, 2019
sindresorhus
requested changes
Jun 9, 2019
|
Tests are failing. |
sindresorhus
added a commit
that referenced
this pull request
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31