Stop using deprecated process.umask()
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just remove the |
|
So you don't think we need to mention that the Side note I have no idea what the issue with node 10 on Windows is. I don't have access to Windows (outside of Travis) so I'm not sure how to troubleshoot this. |
|
Hmm I guess since https://nodejs.org/dist/latest/docs/api/fs.html#fs_fs_mkdir_path_options_callback just says the default is 0o777 so I doing the same here probably makes sense. |
coreyfarrell
force-pushed
the
no-process-umask
branch
from
86f1ba5
to
73c5f65
Compare
|
I don't know about the Windows issue either. And I have no ability to debug it further. |
|
Thanks for fixing this 👍 |
sindresorhus
pushed a commit
that referenced
this pull request
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Note readme.md and index.d.ts both still reference
0o777 & (~process.umask())as the default value to mode. I'm not sure the best way to update these two places.