Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options.method being undefined in normalized options #671

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kleinfreund
Copy link
Contributor

Fix options.method (where options has the NormalizedOptions type) being undefined when no method is provided.

Fixes #670.

@kleinfreund
Copy link
Contributor Author

I'm aware that commits are expected to be squashed; however, I wanted to keep a clean git history while the pull request is under review. I'm happy to squash commits once that's completed.

@sholladay
Copy link
Collaborator

We squash the PR during merge, so the commit messages in the PR will be combined to a bulleted list in a single commit on the main branch. Up to you whether or not you want to clean up the PR commits before the merge or not. But strictly speaking, there's no need to do your own squash unless you want to.

Fix `options.method` (where `options` has the `NormalizedOptions` type) being `undefined` when no method is provided.

Fixes sindresorhus#670.
@kleinfreund kleinfreund force-pushed the fix/method-being-undefined branch from e59006d to bbabb86 Compare February 11, 2025 18:52
@kleinfreund
Copy link
Contributor Author

Thanks, I squashed them now as I had used a bit of a different commit message style in the last two commits out of habit.

@sholladay sholladay merged commit 762ea4c into sindresorhus:main Feb 12, 2025
1 check passed
@kleinfreund kleinfreund deleted the fix/method-being-undefined branch February 12, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalized options mark method as required, but it can be undefined
2 participants