Allow returning Response from a beforeRequest hook
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus can you restart travis please ? the failed build seems to be some random puppeteer timeout. |
|
@hugomrdias |
|
cool then this is ready for review |
szmarczak
reviewed
Sep 9, 2019
szmarczak
reviewed
Sep 9, 2019
index.js
Outdated
| @@ -383,7 +383,10 @@ class Ky { | |||
| async _fetch() { | |||
| for (const hook of this._hooks.beforeRequest) { | |||
| // eslint-disable-next-line no-await-in-loop | |||
| await hook(this._input, this._options); | |||
| const hookOutput = await hook(this._input, this._options); | |||
szmarczak
reviewed
Sep 9, 2019
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
szmarczak
changed the title
Response from a beforeRequest hook
|
The docs part should have been added to index.d.ts. Otherwise, looks good. |
|
I think the types should also be updated 🤔 can't get TS to accept returning a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to return a Response from the beforeRequest hook and completely skip the HTTP request.
closes #157
/cc @lidel