Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on termination #73

Merged
merged 1 commit into from
Jan 4, 2015
Merged

Add note on termination #73

merged 1 commit into from
Jan 4, 2015

Conversation

morenoh149
Copy link
Contributor

How to kill the test if it does not terminate after finishing.
Closes #54

How to kill the test if it does not terminate after finishing.
@morenoh149
Copy link
Contributor Author

@sindresorhus travis ci is failing here because you have a purposely failing test here https://github.com/sindresorhus/gulp-mocha/blob/master/fixture-fail.js#L5

sindresorhus added a commit that referenced this pull request Jan 4, 2015
@sindresorhus sindresorhus merged commit a02ba14 into sindresorhus:master Jan 4, 2015
@juanpabloaj
Copy link

@morenoh149 but, if I add process.exit(); this kill the gulp.watch command

@gregberge
Copy link
Contributor

@morenoh149 how about the return code?

@gregberge
Copy link
Contributor

The good way to do it is:

return gulp.src('test/**/*', {read: false})
  .pipe(mocha())
  .once('error', function () {
    process.exit(1);
  })
  .once('end', function () {
    process.exit();
  });

@morenoh149
Copy link
Contributor Author

@neoziro @juanpabloaj submit a pull request :)

@gregberge
Copy link
Contributor

@morenoh149 done #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gulp-Mocha fails to exit, but Mocha does
4 participants