Added 'binVersion' option to specify against which version to test - solves an issue on Ubuntu #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed in a dependency. Just reinstall this task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
On Ubuntu my php reports version '5.5.9-1ubuntu4.4'.
This fails the built-in PHP version check '>=5.4', because semver believes '1ubunbu4.4' is a pre-release tag, and pre-release tags do not match version range (unless they're explicitly listed, see npm/node-semver#99 (comment)).
So grunt-php aborts.
To solve it I added an option to specify the version to check against, and I set it to '*' (which matches), but it could also be used to ensure PHP>=5.5, if
Default is still >=5.4, so it is fully backward-compatible.