Upgrade to ESLint 8 and require Node.js 12 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex1st
changed the title
| @@ -3,7 +3,7 @@ module.exports = grunt => { | |||
| grunt.initConfig({ | |||
| eslint: { | |||
| options: { | |||
| configFile: 'conf/eslint.json', | |||
| overrideConfigFile: 'conf/eslint.json', | |||
There was a problem hiding this comment.
Why are you changing the option name?
There was a problem hiding this comment.
Hello @sindresorhus because 'configFile' option is deprecated in v8. If you run the test with that option eslint prints the error message:
Warning: Invalid Options:
- Unknown options: configFile
- 'configFile' has been removed. Please use the 'overrideConfigFile' option instead. Use --force to continue.
tasks/eslint.js
Outdated
|
|
||
| const engine = new eslint.CLIEngine(options); | ||
| const engine = new ESLint({ overrideConfigFile, rulePaths }); |
There was a problem hiding this comment.
We document that the user can pass any option to ESLint, not just these.
There was a problem hiding this comment.
Oh, make sense. But the new version of eslint validates options and throws an error if an option is unknown. I changed to reverted logic for destructing options.
|
The link to ESLint option in the readme needs to be updated. |
|
The link was updated. |
return42
added a commit
to searxng/searxng
that referenced
this pull request
Oct 22, 2021
sindresorhus/grunt-eslint#171 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
dalf
pushed a commit
to dalf/searxng
that referenced
this pull request
Nov 17, 2021
sindresorhus/grunt-eslint#171 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
dalf
pushed a commit
to searxng/searxng
that referenced
this pull request
Nov 17, 2021
sindresorhus/grunt-eslint#171 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.