Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export useful types for end-users #889

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Conversation

jaulz
Copy link
Contributor

@jaulz jaulz commented Sep 23, 2019

As discussed in #876 this PR exports most of the types in the index file, e.g. instead of:

import { CancelableRequest, Response } from 'got/dist/utils/types'
import { Got, GotStream } from 'got/dist/create'
import { ProxyStream } from 'got/dist/as-stream'

it would be:

import { Got, GotStream, ProxyStream, CancelableRequest, Response } from 'got'

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

source/index.ts Outdated Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title fix: export types from index Export useful types for end-users Sep 23, 2019
@sindresorhus sindresorhus merged commit afe3081 into sindresorhus:master Sep 23, 2019
@jaulz jaulz deleted the patch-4 branch September 23, 2019 11:47
@jaulz
Copy link
Contributor Author

jaulz commented Sep 23, 2019

Thanks!

@sindresorhus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants