Disable a test as the built-in openssl on macOS does not support negative days
#1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
openssl on macOS does not support negative days
sindresorhus
approved these changes
Sep 10, 2020
|
I think we can leave this test disabled for MacOS. The CI infrastructure is based on Linux, we can catch this problem. If it doesn't work on MacOS (but works on Linux) the problem is probably going to be the openssl on MacOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title self-explanatory.
Reference: https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=osx1015/935/testReport/junit/(root)/citgm/got_v11_6_1/
The test has been disabled, I'm looking for some kind of replacement. We cannot play with timers because the TLS logic related to the certificate expiration is done by openssl.