-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent Electron support (#311) breaks in Atom #314
Comments
What are you trying to use it for? Are using it with browserify/webpack in an Atom plugin? |
No, I'm testing out code by requiring from the Atom developer tools. I'm using a customized version of https://github.com/douglascalhoun/eval-javascript to eval code on the fly. It's admittedly an edge case, but might be relevant to plugin developers. |
And support using it in the renderer process => #314
@lselden Can you try latest master? I added support for running in the Electron renderer process. |
And support using it in the renderer process => #314
Re Pull: #311
I'm on the latest atom version (v1.17.1), and
require('electron').net
returnsundefined
, so attempting to use got I get:relevant line:
https://github.com/sindresorhus/got/blob/master/index.js#L43
quickfix: perhaps instead of:
fn = require('electron').net;
it could be:
fn = require('electron').net || fn;
The text was updated successfully, but these errors were encountered: