-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got doesn't pass query-string when calling via unix-socket #1036
Labels
Comments
If make the reproducing code consistent and pass //reference call with http via TCP/IP port
http.get(
new URL(`http://localhost:${port}/http${search}`),
{headers: {authorization: 'Basic aaa'}},
cb
);
//reference call with got via TCP/IP port
got
.get(new URL(`http://localhost:${port}/got${search}`), {headers: {authorization: 'Basic aaa'}})
.then(cb);
//reference call with http via unix-socket
http.get(
new URL(`http://unix:${socket}:/http${search}`),
{socketPath: '/tmp/app.sock', headers: {authorization: 'Basic aaa'}},
cb
);
//testing call with got via unix-socket
got
.get(new URL(`http://unix:${socket}:/got${search}`), {headers: {authorization: 'Basic aaa'}})
.then(cb); The output is the same:
|
izonder
changed the title
Got suppresses passing query-string when calling via unix-socket
Got doesn't pass query-string when calling via unix-socket
Jan 24, 2020
Confirmed for macOS as well: Node.js version: v12.13.1 |
szmarczak
added a commit
to szmarczak/got
that referenced
this issue
Feb 29, 2020
szmarczak
added a commit
to szmarczak/got
that referenced
this issue
Mar 3, 2020
szmarczak
added a commit
to szmarczak/got
that referenced
this issue
Mar 4, 2020
Also noticed this. This is a regression, v9.6.0 does work. |
Is there any workaround for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Actual behavior
Making a call via UNIX-socket results in not passing query string in URL. When making a call via normal TCP/IP port it works correctly. For example, for the code below we have received the output:
Expected behavior
Having query string in request in both cases. For example, for the code below it's expected the output:
or at least:
Code to reproduce
Checklist
The text was updated successfully, but these errors were encountered: