Support URL as cwd

[fisker]

I build url-or-path few months ago, it actually accept path, URL and URL.href, should we add test for URL.href too?

Fixes #176

[sindresorhus]

I would prefer not to introduce a dependency for this. I have worked very hard in the past year to reduce the amount of dependencies I use. In this case, it's really just cwd.startsWith('file://') ? fileURLToPath(cwd) : cwd.

[sindresorhus]

I think Node.js should expose a method for this. It's such a common need now that everything is starting to support URL. Maybe you wanna open an issue about it on the Node.js repo?

[sindresorhus]

path.from(string | URL) would be nice API.

[fisker]

Removed dependency, and added test for file: string too.

[fisker]

It's such a common need now that everything is starting to support URL. Maybe you wanna open an issue about it on the Node.js repo?

I think this is a temporary need. Once everything supports URL, convert to path won't be necessary. Anyway, nodejs/node#41521

[sindresorhus]

I think this is a temporary need. Once everything supports URL, convert to path won't be necessary. Anyway,

No, there will always be a need as your argument only works if you directly pass the input to a Node.js API. Many packages manipulate the paths somehow and dealing with path and not URL is much nicer then.

[antongolub]

CC @sindresorhus

URL interface belongs to lib.dom.d.ts, so now we force TS users to inject compilerOptions.lib: ['dom'] to resolve URL as global. It breaks TS builds and formally this is a breaking change.

[build:es6   ] ../../node_modules/globby/index.d.ts(54,17): error TS2304: Cannot find name 'URL'.
[build:es6   ] ../../node_modules/globby/index.d.ts(58,17): error TS2304: Cannot find name 'URL'.
[build:es6   ] ../../node_modules/globby/index.d.ts(162,18): error TS2304: Cannot find name 'URL'.

[sindresorhus]

https://nodejs.org/api/url.html#the-whatwg-url-api

[antongolub]

Otherwise it should be explicitly imported in index.d.ts. It does not belong to global by default.

[antongolub]

@sindresorhus
I really don't want to fix hundreds of our globby@^12-dependant projects all night )). Could you plz roll the patch #206?

[fisker]

I'm sorry for breaking your projects, but I know nothing about the typing, I can't help.