Require Node.js 12.20 and move to ESM

[antongolub]

• add named exports
• update all deps to the latest versions
• add Node.js v16 to test matrix
• apply xo --fix
• BREAKING CHANGE: require Node.js >= 12.20
• BREAKING CHANGE: drop default exports, remove all globby.* methods

[sindresorhus]

Thanks for working on this.

You need to update index.d.ts (https://github.com/sindresorhus/typescript-definition-style-guide) and the readme for ESM too.

[sindresorhus]

I think there should be the following named exports:

• globbyAsync
• globbySync
• globbyStream

[antongolub]

Ok. But let's save globby as globbyAsync alias.

[sindresorhus]

I disagree. Aliases cause confusion.

[antongolub]

Maybe just globby and globbySync?

[antongolub]

rfr

[sindresorhus]

I can never decide how to handle named exports with async and sync methods:

• globby and globbySync
• globbyAsync and globbySync

The former looks nicer, but the latter is clearer. Any opinion?

[antongolub]

My guess is that for most users, the migration will look like this:
const globby = require('globby') → import {globbyAsync as globby} from 'globby'.
Well... I'd prefer just import {globby} from 'globby' instead.

[sindresorhus]

Alright. Let's go with globby for async and drop globbyAsync.

[antongolub]

@sindresorhus, your turn

[zloirock]

@sindresorhus sorry, why do you avoid the default export here?

[fisker]

I guess for consistency import? But I think maybe we can export both named and default? export {globby as default, globby}

[sindresorhus]

It's weird to have one default and one named when there are two main exports. I only do default and named export mix when there's only one main export and some secondary exports (like error, or helper utilities).

[sindresorhus]

But I think maybe we can export both named and default? export {globby as default, globby}

No, there should be only one way to import the thing. Aliases create confusion and inconsistency.