Make error.killed and error.isCanceled always boolean (not undefined)
#229
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
changed the title
error.killed and error.isCanceled always boolean (not undefined)error.killed and error.isCanceled always boolean (not undefined)
ehmicky
changed the title
error.killed and error.isCanceled always boolean (not undefined)error.killed and error.isCanceled always boolean (not undefined)
|
Can you fix the merge conflict? |
ehmicky
force-pushed
the
feature/normalize-error
branch
from
a006e43 to
3813056
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
killedandisCanceledproperties oferrorshould always betrueorfalse, notundefined. This makes the interface simpler and more predictable.This PR solves the use cases where it could have been
undefined, e.g. when usingexeca.sync().It also adds related tests.