Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-exponentiation-operator: Fix operator precedence bugs #305

Merged

Conversation

MrHen
Copy link
Contributor

@MrHen MrHen commented May 31, 2019

Fixes #304.

  • Wraps things in parentheses by default
  • Removes parentheses for known safe node types
  • Also turns the fixer off if it detects comments since fixing with comments is non-trivial

@sindresorhus sindresorhus merged commit dc90c1e into sindresorhus:master May 31, 2019
@sindresorhus
Copy link
Owner

sindresorhus commented May 31, 2019

@MrHen Thanks for all your high-quality contributions. ❤️ The project would not be the same without you. Would you be interested in joining the project as a maintainer? (You would still be able to collect bounties on issues)

@MrHen MrHen deleted the bug/304-prefer-exponentiation-operator branch May 31, 2019 11:57
@MrHen
Copy link
Contributor Author

MrHen commented May 31, 2019

@sindresorhus What are the expectations / duties for maintainers?

@sindresorhus
Copy link
Owner

@MrHen It's open source. You do what you feel like. But what I could use help with is reviewing PRs. But again, totally optional.

@MrHen
Copy link
Contributor Author

MrHen commented May 31, 2019

@sindresorhus Sounds good; I'll do what I can to help!

@sindresorhus
Copy link
Owner

Awesome 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: prefer-exponentiation-operator disregards order of operations
2 participants