Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onShow & onClose callbacks #158

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Add onShow & onClose callbacks #158

merged 8 commits into from
Jun 21, 2022

Conversation

hackal
Copy link
Contributor

@hackal hackal commented Jun 13, 2022 •
edited
Loading

Add two callbacks onShow and onClose that are called based on Menu class events menu-will-show and menu-will-close.

In case we need to change UI if context menu is open/closed.

sindresorhus
sindresorhus reviewed Jun 13, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@hackal hackal requested a review from sindresorhus June 17, 2022 12:41
@sindresorhus sindresorhus merged commit d20fa56 into sindresorhus:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackal @sindresorhus