Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak issue when multiple windows are used. #179

Closed
lovemegowin opened this issue Jun 24, 2024 · 0 comments · Fixed by #180
Closed

Memory leak issue when multiple windows are used. #179

lovemegowin opened this issue Jun 24, 2024 · 0 comments · Fixed by #180

Comments

@lovemegowin
Copy link
Contributor

lovemegowin commented Jun 24, 2024

Hi, I discovered a scenario of memory leak that can be reproduced 100% of the time when using multiple windows.

image

When a user creates a new window and closes it, this object will not be released.
Based on my preliminary investigation, The line code won't be executable , because when the events 'closed' trigger, the win.isDestroyed() will always return true

I have create a minimum reproducible repo https://github.com/lovemegowin/electron-context-menu-memory-leak-sample

lovemegowin added a commit to lovemegowin/electron-context-menu that referenced this issue Jun 24, 2024
lovemegowin added a commit to lovemegowin/electron-context-menu that referenced this issue Jun 24, 2024
add semicolon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant