Add another identifier for detecting code signing identity #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
I am registered in the Apple Developer program, but create-dmg was not detecting my code signing identity. When I run:
my stdout looks something like:
Currently create-dmg looks for
Developer ID Application:
orMac Developer:
in the stdout so it was not automatically detecting a valid code signing identity.Solution:
This PR allows create-dmg to use
Apple Development:
when automatically detecting if the user has a code signing identity.With this change, everything works correctly now. I can manually verify that the final dmg was signed using the following (which create-dmg does anyway):
Not sure when Apple started using
Apple Development:
though. For reference, I'm on macOS 13.1 and joined the developer program in 2021. Or maybe I just don't fully understand the code signing identity lol.