Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another identifier for detecting code signing identity #77

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Add another identifier for detecting code signing identity #77

merged 2 commits into from
Jan 12, 2023

Conversation

marwanhawari
Copy link
Contributor

@marwanhawari marwanhawari commented Jan 9, 2023

Problem:

I am registered in the Apple Developer program, but create-dmg was not detecting my code signing identity. When I run:

security find-identity -v -p codesigning

my stdout looks something like:

  1) XXXXXXXXXXXXXXXXXXXXXXXX "Apple Development: Marwan Hawari (XXXXXXXXXX)"
     1 valid identities found

Currently create-dmg looks for Developer ID Application: or Mac Developer: in the stdout so it was not automatically detecting a valid code signing identity.

Solution:

This PR allows create-dmg to use Apple Development: when automatically detecting if the user has a code signing identity.
With this change, everything works correctly now. I can manually verify that the final dmg was signed using the following (which create-dmg does anyway):

codesign ${dmgPath} --display --verbose=2

Not sure when Apple started using Apple Development: though. For reference, I'm on macOS 13.1 and joined the developer program in 2021. Or maybe I just don't fully understand the code signing identity lol.

@sindresorhus sindresorhus merged commit 2f7d282 into sindresorhus:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants