Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v10, the returned promises are not resolved #44

Closed
saneef opened this issue Apr 30, 2018 · 3 comments
Closed

Node v10, the returned promises are not resolved #44

saneef opened this issue Apr 30, 2018 · 3 comments

Comments

@saneef
Copy link

saneef commented Apr 30, 2018

The promise returned by cpy() is not resolved in Node v10. Also, the current test suite fails in Node v10.
@tmcw tmcw mentioned this issue May 2, 2018
Closed
@tmcw
Copy link

tmcw commented May 2, 2018 •
edited
Loading

Looks like the cause is upstream, in cp-file.

@tmcw tmcw mentioned this issue May 2, 2018
Closed
@tmcw
Copy link

tmcw commented May 8, 2018

There's now a working PR in cp-file that will fix v10 compatibility when merged: sindresorhus/copy-file#26

@sindresorhus
Copy link
Owner

Fixed: https://github.com/sindresorhus/cpy/releases/tag/v7.0.0

@popomore popomore mentioned this issue Jul 16, 2018
Merged
This was referenced Oct 20, 2018
Merged
Closed
nicl added a commit to guardian/dotcom-rendering that referenced this issue Aug 28, 2019
@nicl
Use node 10
f5353b1 
As part of this, cpy version has been bumped. See
sindresorhus/cpy#44 (comment)
- previous version did not support Node 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmcw @saneef @sindresorhus