Added TypeScript types. #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing, but has nothing to do with the types. I can fix those issues in another PR if you want. |
|
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide? |
index.d.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| declare const copyToClipboard: { (data: string): boolean; }; | |||
|
|
|||
| export default copyToClipboard; | |||
There was a problem hiding this comment.
Would be simpler to just use export default function copyToClipboard ...
There was a problem hiding this comment.
Yeah, that's what I had initially. Will revert.
nickytonline
commented
Feb 24, 2019
| @@ -18,7 +18,7 @@ module.exports = input => { | |||
| originalRange = selection.getRangeAt(0); | |||
| } | |||
|
|
|||
| document.body.appendChild(el); | |||
| document.body.append(el); | |||
There was a problem hiding this comment.
Fixed issue that failing the build. Not related to types addition.
nickytonline
commented
Feb 24, 2019
| @@ -28,7 +28,7 @@ module.exports = input => { | |||
| let success = false; | |||
| try { | |||
| success = document.execCommand('copy'); | |||
| } catch (err) {} | |||
| } catch (error) {} | |||
There was a problem hiding this comment.
Fixed issue that failing the build. Not related to types addition.
|
No rush @sindresorhus, but just wondering if there is anything else you'd like me to do for this PR. |
|
I went with #24 as it was more complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds TypeScript types. We'd need these for completing the transition to TypeScript for Refined GitHub, refined-github/refined-github#1783