Always throw if unable to overwrite

[boneskull]

This is a breaking change

Fixes #37

[boneskull]

Maybe more appropriate to say "always throw (or reject) on copy failure"

[boneskull]

node v12.13.0 introduced a breaking change, I'll investigate

[boneskull]

I've added a change to work around the issue (version sniffing! fun!)

[boneskull]

@sindresorhus You may want to comment on nodejs/node#29930 as I don't think I can be very much help

[mcollina]

I think you should wait for open to be emitted on the writable stream as well before piping. I’m not sure why this was not causing problem before, as it seems a race condition to me between the readable and writable sides.

[boneskull]

I'm not sure what's going on here.

[sindresorhus]

@boneskull It's not clear to me what the status of this PR is?

[boneskull]

I’m not sure what to do with @matteocollina’s feedback. there’s a workaround in this PR, and afaik the PR works, but I’m unsure if I should be changing something else per his feedback

[sindresorhus]

@mcollina The docs says nothing about having to wait for an open event: https://nodejs.org/api/fs.html#fs_fs_createwritestream_path_options

[sindresorhus]

I've added it just in case though: 6d92d5c

[sindresorhus]

Reverted that ^. It caused problems on Node.js 12 (I apparently had an older 12 version locally so I didn't detect the problem before pushing). https://travis-ci.org/sindresorhus/cp-file/jobs/654317803?utm_medium=notification&utm_source=email