Updates for main #2019
Updates for main #2019
Conversation
|
Here are some comments but I will open reviews for a few pieces of code.
Why?
We only provide exe installer. This is not an issue then.
Okay.
Your name will be present on the win7 variant. |
| .x9f619.x1n2onr6.x1ja2u2z.x78zum5.x2lah0s.x1qughib.x6s0dn4.xozqiw3.x1q0g3np.x1sy10c2.xktsk01.xod5an3.x1d52u69.xzd29fr { | ||
| -webkit-app-region: drag; | ||
| } | ||
| [role='navigation'] .x16n37ib { | ||
| -webkit-app-region: no-drag; | ||
| } | ||
| .x9f619.x1n2onr6.x1ja2u2z.x78zum5.xdt5ytf.x193iq5w.xeuugli.x1r8uery.x1iyjqo2.xs83m0k.xsyo7zv.x16hj40l.x10b6aqq.x1yrsyyn { | ||
| -webkit-app-region: drag; | ||
| } | ||
| [role='navigation'] .x1heor9g.x1qlqyl8.x1pd3egz.x1a2a7pz { | ||
| margin-left: 60px; | ||
| } |
There was a problem hiding this comment.
I this is for macOS, it's already fixed #2014
| "target": { | ||
| "target": "default", | ||
| "arch": [ | ||
| "x64", | ||
| "arm64" | ||
| ] | ||
| }, |
| @@ -47,7 +47,7 @@ | |||
|
|
|||
| ## Install | |||
|
|
|||
| *macOS 10.10+, Linux, and Windows 10+ are supported (64-bit only).* | |||
| *macOS 10.12+ (Intel and Apple Silicon), Linux (x64 and arm64), and Windows 10+ (64-bit) are supported.* | |||
| @@ -59,6 +59,14 @@ if (!config.get('hardwareAcceleration')) { | |||
| app.disableHardwareAcceleration(); | |||
| } | |||
|
|
|||
| if (config.get('hardwareAcceleration')) { | |||
There was a problem hiding this comment.
If you're reading config of the app, the property should be defined in source/config.ts and also you should define migrations so the property gets created after an update.
| trafficLightPosition: { | ||
| x: 80, | ||
| y: 20, | ||
| }, |
|
And please rebase to main so this branch would be up to date. |
This adds more icon sizes for linux, and adds a new windows icon constant.
Right now, our windows builds have no icon. The icon is generated by electron builder from the Icon.png.
This is problematic because only will the icon be set if someone is using the .exe installer. Using a .zip or building from source on Linux makes it use the default electron icon.
Another problem is that the icon generated only has one size, 512px.
A proper windows icon (and proper windows electron app) should use a windows .ico file that has 16px, 32px, 48px, 64px, and 256px embedded inside.
This also adds a new menu item to the debug menu, opening a chrome://gpu window to check hardware acceleration status. It also checks the hardwareacceleration user config, and appends ignore-gpu-blocklist to electron if it is not false.
Other changes include adding my name to the About window, and adding QUIC support, as many facebook and google domains use this, and it enables faster handshaking.