Various tweaks #1267
Merged
Various tweaks #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Feb 5, 2020
source/index.ts
Outdated
| @@ -285,6 +286,7 @@ function createMainWindow(): BrowserWindow { | |||
| webPreferences: { | |||
| preload: path.join(__dirname, 'browser.js'), | |||
| contextIsolation: true, | |||
| spellcheck: true, | |||
There was a problem hiding this comment.
I'm not sure about this. When the user sees the red squiggly lines, they assume they can right-click to get suggestion for spelling, which currently won't happen. I think we should wait for sindresorhus/electron-context-menu#11 (comment).
There was a problem hiding this comment.
Trying to work on it. Will submit a pull request when i figure it out
There was a problem hiding this comment.
Check out the PR sindresorhus/electron-context-menu#94. This was my first time working with any library. Took some time to understand the code, but enjoyed working on it🎉
|
Sorry about the merge conflict. I was already working on updating the dependencies. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron 8.0.0 is out. #14.
IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor