Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid escape in test string #65

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Sep 26, 2021

\8 is invalid in strict mode, it can run because we didn't enforce strict mode.

Found this in [eslint-plugin-unicorn tests] (https://github.com/sindresorhus/eslint-plugin-unicorn/runs/3672252186#step:5:363)

Boxen should protect this alignement,
otherwise the users would be sad !
Hehe Haha
Hehe Haha${' '.repeat(33)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the space is useful in tests, but

trim_trailing_whitespace = true
, we should not write it directly.

@sindresorhus sindresorhus merged commit 84d24fe into sindresorhus:main Sep 26, 2021
@fisker fisker deleted the invalid-escape branch September 26, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants